Finishes altering initialize to use a type-safe DSL #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
==========================================
+ Coverage 63.97% 64.41% +0.43%
==========================================
Files 154 154
Lines 3126 3119 -7
Branches 317 315 -2
==========================================
+ Hits 2000 2009 +9
+ Misses 1034 1020 -14
+ Partials 92 90 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fractalwrench
force-pushed
the
fw/dsl-params-2
branch
2 times, most recently
from
797a883 to
bf91985
Compare
fractalwrench
force-pushed
the
fw/dsl-params-2
branch
from
bf91985 to
31d199a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Builds on #1292 by using a type-safe DSL rather than individual parameters. The last commit contains the changes for this PR specifically. Essentially, I have moved the
globalAttributesanddiskBufferingparameters ontoOpenTelemetryConfiguration.I also hid some values that are no longer publicly accessed from the public API by making them internal, and made some constructors internal too.